Skip to content

Conversation

@keith-turner
Copy link
Contributor

The new test in this commit covers the following code

log.info("Tablet {} no longer needs to split, deleting unsplittable marker.",
tabletMetadata.getExtent());
var mutator = tabletsMutator.mutateTablet(extent).requireAbsentOperation()
.requireSame(tabletMetadata, FILES).deleteUnSplittable();
mutator.submit(tm -> tm.getUnSplittable() == null);
// Case 3: The table config and/or set of files changed since the tablet mgmt iterator
// examined this tablet.

@keith-turner keith-turner added this to the 4.0.0 milestone Aug 8, 2024
@keith-turner keith-turner linked an issue Aug 8, 2024 that may be closed by this pull request
@keith-turner
Copy link
Contributor Author

keith-turner commented Aug 8, 2024

As a result of running this test and looking at the coverage data #4792 and #4793 were opened. The test will run without those changes, but will not get full code coverage.

Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice test to add to confirm deletion works when the threshold changes to go along with the test that the unsplittable column was added when the tablet can't be split. I went back and took a look and there is an existing IT that covers this case but I forgot to add one to the ManagerRepoIT after TestAmple was created.

So now we have tests for the column creation/deletion both using TestAmple to simulate things as well as with an IT that uses the real system Ample and metadata which is nice.

@keith-turner
Copy link
Contributor Author

I went back and took a look and there is an existing IT that covers this case but I forgot to add one to the ManagerRepoIT after TestAmple was created.

That was a good find. I added links in the javadoc for each test pointing to the other. Since the test are somewhat similar it may be useful to know about the other test when making changes in the future.

@keith-turner keith-turner merged commit cc95159 into apache:elasticity Aug 9, 2024
@keith-turner keith-turner deleted the find-splits-test-improvement branch August 9, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase coverage of conditional mutation rejection handling code.

2 participants