Added runtime check for shared compaction queues #4800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Marking as draft because I'm not sure if we should log the error and not perform compactions, or exit the Manager. |
ddanielr
reviewed
Aug 12, 2024
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java
Outdated
Show resolved
Hide resolved
ddanielr
approved these changes
Aug 12, 2024
Contributor
|
LGTM |
cshannon
approved these changes
Aug 16, 2024
Contributor
Author
|
This change is causing test failures. Specifically |
Contributor
Author
|
Created #4813 to fix the ITs. |
dlmarion
added a commit
that referenced
this pull request
Aug 20, 2024
Changes introduced in #4800 to validate compaction configurations caused several ITs to start failing. In these cases the ITs were using invalid configurations. The changes here fix the ITs by either isolating the invalid configurations to only the associated tests (vs having the invalid configuration persist for all the tests in the class), or I made modifications to the test so that they would continue to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4034