Skip to content

Resolve todo in ServerContextTest for upgrade test #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlmarion merged 1 commit into from
Aug 23, 2024
Merged

Resolve todo in ServerContextTest for upgrade test #4822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ public void testSasl() throws Exception {
@Test
public void testCanRun() {
final int oldestSupported = AccumuloDataVersion.oldestUpgradeableVersion();
// ELASTICITY_TODO #4587 basically disable check until upgrade is working. Should be:
// assertEquals(10, oldestSupported); // make sure it hasn't changed accidentally
assertEquals(10, oldestSupported); // make sure it hasn't changed accidentally
final int currentVersion = AccumuloDataVersion.get();
IntConsumer shouldPass = ServerContext::ensureDataVersionCompatible;
IntConsumer shouldFail = v -> assertThrows(IllegalStateException.class,
Expand Down