Fixes json extraction in FateSummaryIT#5002
Merged
keith-turner merged 2 commits intoapache:2.1from Oct 18, 2024
Merged
Conversation
FateSummaryIT ran an external command that would output log messages and json. The test wanted to extract only the json from the command output. The extraction was broken by a recent change to log messages that included a curly brace. Modified the extraction to tolerate this.
kevinrr888
approved these changes
Oct 18, 2024
keith-turner
added a commit
that referenced
this pull request
Oct 18, 2024
FateOpsCommandsIT ran an external command that would output log messages and json. The test wanted to extract only the json from the command output. The extraction was broken by a recent change to log messages that included a curly brace. Modified the extraction to tolerate this. These are the same fixes made in #5002, just in a different class.
Contributor
Author
@kevinrr888 that tip was really helpful in knowing where to fix things in 4.0. Instead of making a bunch of changes in a merge commit, I made a follow on commit in main after the merge commit to fix the problem there. Did that in af8a11c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FateSummaryIT ran an external command that would output log messages and json. The test wanted to extract only the json from the command output. The extraction was broken by a recent change to log messages that included a curly brace. Modified the extraction to tolerate this.