Fix bug with GC not scanning root table for file refs#503
Merged
keith-turner merged 2 commits intoapache:masterfrom May 30, 2018
Merged
Fix bug with GC not scanning root table for file refs#503keith-turner merged 2 commits intoapache:masterfrom
keith-turner merged 2 commits intoapache:masterfrom
Conversation
This bug was introduced in 9feb5e1. In addition to fixing the bug, specifying the table was made mandatory for the metadata scanner builder. The bug was found by MetadataMaxFilesIT
ctubbsii
approved these changes
May 29, 2018
| @Override | ||
| public RangeOptions scanMetadataTable() { | ||
| this.table = MetadataTable.NAME; | ||
| return this; |
Member
There was a problem hiding this comment.
I always wonder, in these cases where the implementation for setting a single parameter is trivial, is it better to do what is here, or is it better to do:
@Override
public RangeOptions scanMetadataTable() {
return scanTable(MetadataTable.NAME);
}
Contributor
Author
There was a problem hiding this comment.
I like that, its shorter. I updated the code.
| /** | ||
| * Optionally set a table name, defaults to {@value MetadataTable#NAME} | ||
| */ | ||
| public interface TableOptions { |
Member
There was a problem hiding this comment.
Does removing extends RangeOptions effectively make this a required parameter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was introduced in 9feb5e1. In addition to fixing the bug,
specifying the table was made mandatory for the metadata scanner
builder.
The bug was found by MetadataMaxFilesIT