Remove tserver lock entries per group#5199
Closed
ddanielr wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
Removes all tserver lock entries when a group of tservers is stopped or killed.
dlmarion
reviewed
Dec 19, 2024
ctubbsii
reviewed
Dec 23, 2024
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Should be rebased, to make sure it works with the latest changes, including the addition of the colorized output. A few minor tweaks, but otherwise, looks good.
| if [[ $ARG_TSERVER == 1 ]]; then | ||
| if ! isDebug; then | ||
| echo "Cleaning all tserver entries in ZooKeeper" | ||
| $accumulo_cmd org.apache.accumulo.server.util.ZooZap -tservers -group "$zap_group" |
Member
There was a problem hiding this comment.
This needs to be quoted because it can contain spaces in the path.
Suggested change
| $accumulo_cmd org.apache.accumulo.server.util.ZooZap -tservers -group "$zap_group" | |
| "$accumulo_cmd" org.apache.accumulo.server.util.ZooZap -tservers -group "$zap_group" |
| if [[ $ARG_LOCAL == 0 && ($operation == "stop" || $operation == "kill") ]]; then | ||
| if [[ $ARG_TSERVER == 1 ]]; then | ||
| if ! isDebug; then | ||
| echo "Cleaning all tserver entries in ZooKeeper" |
Member
There was a problem hiding this comment.
Suggested change
| echo "Cleaning all tserver entries in ZooKeeper" | |
| echo "Cleaning all $(yellow tserver) entries in ZooKeeper" |
| elif [[ $ARG_ALL == 1 ]]; then | ||
| if ! isDebug; then | ||
| echo "Cleaning all server entries in ZooKeeper" | ||
| $accumulo_cmd org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers |
Member
There was a problem hiding this comment.
Suggested change
| $accumulo_cmd org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers | |
| "$accumulo_cmd" org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers |
Contributor
Contributor
Author
|
Closing this in favor of #5321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all tserver lock entries when a group of tservers is stopped or killed.
Requires #5174 to be merged in beforehand.
Closes #5178