Fix Auditing for new Bulk Import / remove warnings#523
Merged
ctubbsii merged 2 commits intoapache:masterfrom Jun 7, 2018
Merged
Fix Auditing for new Bulk Import / remove warnings#523ctubbsii merged 2 commits intoapache:masterfrom
ctubbsii merged 2 commits intoapache:masterfrom
Conversation
* Fix a bunch of warnings * Ensure new Bulk Import requests are audited * Remove unneeded deprecation of internal impl code for old bulk import * Remove unnecessary Serializable for new Bulk code mapping information * Use new bulk import in some tests when not specifically testing an old bulk import behavior * Remove some unused variables from tests (left commented out for reference to ongoing improvements to client configuration code)
keith-turner
approved these changes
Jun 7, 2018
| @@ -116,18 +116,8 @@ static void checkRFiles(Connector c, String tableName, int minTablets, int maxTa | |||
|
|
|||
| static public void bulkImport(Connector c, FileSystem fs, String table, String dir) | |||
Contributor
There was a problem hiding this comment.
maybe this method can be inlined now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference to ongoing improvements to client configuration code)