Removed escaping from quotes in ext comp metadata file references#5237
Merged
dlmarion merged 4 commits intoapache:mainfrom Jan 8, 2025
Merged
Removed escaping from quotes in ext comp metadata file references#5237dlmarion merged 4 commits intoapache:mainfrom
dlmarion merged 4 commits intoapache:mainfrom
Conversation
Moved CompactionMetadata class so that internal object that contains path and range for the file could be reused. Closes apache#5060
keith-turner
approved these changes
Jan 8, 2025
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java
Outdated
Show resolved
Hide resolved
cshannon
approved these changes
Jan 8, 2025
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java
Outdated
Show resolved
Hide resolved
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Jan 9, 2025
The changes in apache#5237 to make the external compaction json metadata entry easier to use ended up breaking FileNormalizationIT. apache#5237 removed the metadata entry string which ended up escaping the double quotes in the string for the json and replaced it with an object that contains the path, start, and end row. The problem with this is that the metadata entry retains any misnormalization of the file name (e.g. double slashes in the path) and that path alone does not. This fixes the issue by putting the metadata entry into the new object that is serialized to json so that the json for the external compaction files now contains the metadata entry, normalized path, start and end row.
Contributor
Author
|
This commit was reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved CompactionMetadata class so that internal object that contains path and range for the file could be reused.
Closes #5060