Skip to content

Fix issue with ZooPropEditor setting classloader context property#5238

Merged
dlmarion merged 2 commits intoapache:2.1from
dlmarion:5198-prop-editor-set-context
Jan 8, 2025
Merged

Fix issue with ZooPropEditor setting classloader context property#5238
dlmarion merged 2 commits intoapache:2.1from
dlmarion:5198-prop-editor-set-context

Conversation

@dlmarion
Copy link
Copy Markdown
Contributor

@dlmarion dlmarion commented Jan 8, 2025

The root cause of the issue is that ClassLoaderUtil.initContextFactory was not being called which caused an NPE to be thrown which returned false from ClassLoaderUtil.isValidContext.

Closes #5198

The root cause of the issue is that ClassLoaderUtil.initContextFactory
was not being called which caused an NPE to be thrown which returned
false from ClassLoaderUtil.isValidContext.

Closes apache#5198
@dlmarion dlmarion added this to the 2.1.4 milestone Jan 8, 2025
@dlmarion dlmarion requested a review from ddanielr January 8, 2025 18:01
@dlmarion dlmarion self-assigned this Jan 8, 2025
Copy link
Copy Markdown
Contributor

@ddanielr ddanielr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dlmarion dlmarion merged commit 25dcfbf into apache:2.1 Jan 8, 2025
@dlmarion dlmarion deleted the 5198-prop-editor-set-context branch January 8, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test if Zoo-prop-editor can set classpath context without the manager running

2 participants