Skip to content

Bump compiler source and target versions from Java 11 to Java 17 #5830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlmarion merged 1 commit into from
Aug 28, 2025
Merged

Bump compiler source and target versions from Java 11 to Java 17 #5830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@
<failsafe.reuseForks>false</failsafe.reuseForks>
<!-- prevent introduction of new compiler warnings -->
<maven.compiler.failOnWarning>true</maven.compiler.failOnWarning>
<maven.compiler.release>11</maven.compiler.release>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.javadoc.failOnWarnings>true</maven.javadoc.failOnWarnings>
<maven.site.deploy.skip>true</maven.site.deploy.skip>
<maven.site.skip>true</maven.site.skip>
Expand Down
2 changes: 1 addition & 1 deletion test/src/main/java/org/apache/accumulo/test/zookeeper/ZooCacheIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ public void testZookeeperRestart() throws Exception {
});
}

@SuppressWarnings("deprecation")
@SuppressWarnings({"deprecation", "removal"})
Copy link
Contributor

@keith-turner keith-turner Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this code emit a new warning when compiling w/ jdk17?

Copy link
Contributor Author

@dlmarion dlmarion Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thread.suspend and Thread.resume are marked for removal. I had to add this to compile successfully.

Copy link
Member

@ctubbsii ctubbsii Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we're going to have to fix these, not suppress them.

Copy link
Member

@ctubbsii ctubbsii Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #5846

@Test
public void testDisconnect() throws Exception {
testDisruptingZookeeper("disconnect", () -> {
Expand Down