removes setting table prop in site config in PerTableCryptoIT #5921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerTableCryptoIT was setting a table prop when it did not need to and this was failing. Removed setting the table prop and since the test already set the general prop for the crypto service to AES the test works w/o any additional changes. follow up for apache#5886
keith-turner
commented
Sep 23, 2025
| args.add(new Path(hadoopConfDir, "hdfs-site.xml").toString()); | ||
| } | ||
| args.add("-o"); | ||
| args.add(TABLE_SERVICE_NAME_PROP + "=" + AESCryptoService.class.getName()); |
Contributor
Author
There was a problem hiding this comment.
Earlier in the test on line 75 it does the following
cfg.setProperty(GenericCryptoServiceFactory.GENERAL_SERVICE_NAME_PROP,
AESCryptoService.class.getName());so w/ that setting the table prop is not needed, PrintInfo will still use AES
Member
There was a problem hiding this comment.
I don't think the per-table property would have worked anyway, since there's no table context when using PrintInfo using an RFile path. In theory, it could guess based on the path, but it shouldn't do that. If it tried to do that, I'd consider it a bug. The general prop is the right one to set for this.
ddanielr
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PerTableCryptoIT was setting a table prop when it did not need to and this was failing. Removed setting the table prop and since the test already set the general prop for the crypto service to AES the test works w/o any additional changes.
follow up for #5886