Migrate External Compactions Monitor Page to rest-v2#6155
Merged
DomGarguilo merged 3 commits intoapache:mainfrom Feb 26, 2026
Merged
Migrate External Compactions Monitor Page to rest-v2#6155DomGarguilo merged 3 commits intoapache:mainfrom
DomGarguilo merged 3 commits intoapache:mainfrom
Conversation
Member
Author
|
No UI changes made here but a screenshot anyway to help verify things are working |
ddanielr
reviewed
Feb 25, 2026
| ecInfo.setCompactors(compactors); | ||
| ecInfo.setCoordinatorHost(coordinatorHost); | ||
| return ecInfo; | ||
| return new ExternalCompactorSnapshot(coordinatorHost, compactors, System.currentTimeMillis()); |
Contributor
There was a problem hiding this comment.
A couple of these methods attempt to validate that coordinatorHost is not an empty optional.
This might be outside the scope of this change, but should a snapshot be created if the coordinator doesn't exist?
Member
Author
There was a problem hiding this comment.
Yea I dont think we want to snapshot when the coordinator does not exist. Made that change in a91167a which allowed for a bit more cleanup too which is nice.
ddanielr
approved these changes
Feb 25, 2026
Contributor
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
Had a question that's outside the scope of these changes.
Tested and confirmed they are working.
Did not see any ec related error messages in the console logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the External Compactions monitor page from
restendpoints to the newerrest-v2.rest-v2endpoints to pull the data to populate the external compaction page/next/. These were mostly just moved and light refactor (usedrecordwhere makes sense) of existing objects (which are now unused + removed as of this PR).Monitor.javato replaceExternalCompactionInfowith an internal snapshot classThis task was brought up in #6145 as a worthy follow-on