Open
Conversation
dlmarion
reviewed
Mar 4, 2026
Comment on lines
130
to
136
| NamespaceId id = null; | ||
| try { | ||
| id = getNamespaceId(context, namespaceName); | ||
| } catch (NamespaceNotFoundException e) { | ||
| if (log.isDebugEnabled()) { | ||
| log.debug("Failed to find namespace ID from name: " + namespaceName, e); | ||
| } | ||
| // not found is the expected outcome - callers handle null return | ||
| } | ||
| return id; |
Contributor
There was a problem hiding this comment.
Could potentially simplify to:
try {
return getNamespaceId(context, namespaceName);
} catch NamespaceNotFoundExceptione) {
return null;
}
Comment on lines
+414
to
+419
| // conflicting iterator with same name and different priority | ||
| IteratorSetting conflictingSetting = new IteratorSetting(setting.getPriority() + 1, | ||
| setting.getName(), setting.getIteratorClass()); | ||
| var e = assertThrows(AccumuloException.class, | ||
| () -> c.namespaceOperations().checkIteratorConflicts(namespace, conflictingSetting, | ||
| EnumSet.allOf(IteratorScope.class))); |
Contributor
There was a problem hiding this comment.
This changes seems unrelated to #6045.
Edit: Nevermind this comment, I see now you are trying to fix an IT.
Contributor
Author
There was a problem hiding this comment.
It is but when running the IT was throwing an error for this test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #6045
I removed the log from
lookupNamespaceId, the DEBUG log was misleading since its a "fail quietly" wrapper aroundgetNamespaceIdand was intended to "fail" there. It looks like its called during namespace creation specifically to check that the namespace does not yet exist and should fail quietly and the null return is handled by the methods that call it.Additionally I fixed the error thrown in
namspacesIT. The test was expecting for an error thrown but was being passed the same iterator.IteratorConfigUtilintentionally skips conflict detection when the iterator being checked is the same as an existing one, reattaching the same iterator is not an error.