remove compactor status update#6252
Merged
keith-turner merged 1 commit intoapache:mainfrom Mar 26, 2026
Merged
Conversation
dlmarion
reviewed
Mar 26, 2026
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
Outdated
Show resolved
Hide resolved
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
Show resolved
Hide resolved
dlmarion
approved these changes
Mar 26, 2026
Co-authored-by: Dave Marion <dlmarion@apache.org>
keith-turner
force-pushed
the
remove-update-status
branch
from
f024e86 to
f25503b
Compare
dlmarion
reviewed
Mar 27, 2026
Comment on lines
-467
to
-481
| /** | ||
| * Send an update to the CompactionCoordinator for this job | ||
| * | ||
| * @param job compactionJob | ||
| * @param update status update | ||
| * @throws RetriesExceededException thrown when retries have been exceeded | ||
| */ | ||
| protected void updateCompactionState(TExternalCompactionJob job, TCompactionStatusUpdate update) | ||
| throws RetriesExceededException { | ||
| long updateTime = System.currentTimeMillis(); | ||
| TExternalCompaction tec = JOB_HOLDER.getCurrentCompaction(); | ||
| if (update.getState() == TCompactionState.STARTED) { | ||
| tec.setStartTime(updateTime); | ||
| } | ||
| tec.putToUpdates(updateTime, update); |
Contributor
There was a problem hiding this comment.
I think removing this is causing test failures. I think this functionality should be added back in, to include where this method was called from within the Compactor.
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Mar 27, 2026
The changes in apache#6252 removed code to report state back to the Coordinator and removed the code that was tracking the state of the compaction in the Compactor. The latter is still needed. This puts it back.
keith-turner
pushed a commit
that referenced
this pull request
Mar 27, 2026
The changes in #6252 removed code to report state back to the Coordinator and removed the code that was tracking the state of the compaction in the Compactor. The latter is still needed. This puts it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the status update message sent to the coordinator. This is a follow on to #6244