Skip to content

Fix performance of crypto #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milleruntime merged 2 commits into from
Sep 20, 2018
Merged

Fix performance of crypto #652

milleruntime merged 2 commits into from
Sep 20, 2018

Conversation

@milleruntime
Copy link
Contributor

@milleruntime milleruntime commented Sep 19, 2018

  • Remove use of DiscardCloseOutputStream from WAL encryption
  • Override inefficient write method in DiscardCloseOutputStream and NoFlushOutputStream
  • Changed NoFlushOutputStream to extend FilterOutputStream, which doesn't have synchronized methods like DataOutputStream does

@milleruntime milleruntime merged commit 65639f3 into apache:master Sep 20, 2018
@milleruntime milleruntime deleted the crypto-streams branch September 20, 2018 17:51
@ctubbsii ctubbsii added this to the 2.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keith-turner keith-turner keith-turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@milleruntime @keith-turner @ctubbsii