Verifying whether JAVA_HOME is set or not#772
Merged
keith-turner merged 2 commits intoapache:masterfrom Nov 27, 2018
deeyes24:check_java_home
Merged
Verifying whether JAVA_HOME is set or not#772keith-turner merged 2 commits intoapache:masterfrom deeyes24:check_java_home
keith-turner merged 2 commits intoapache:masterfrom
deeyes24:check_java_home
Conversation
keith-turner
approved these changes
Nov 19, 2018
ctubbsii
approved these changes
Nov 19, 2018
Member
There was a problem hiding this comment.
This is a good sanity check. Ultimately, though, these scripts shouldn't be assuming anything about the path or environment other than what is satisfied by Maven. It'd be good to eventually convert these to a separate execution of Maven compiler plugin. (Perhaps by using Maven invoker).
Contributor
|
Thanks for the contribution @deeyes24 . If you would like to be added as a contributor make a PR at https://github.com/apache/accumulo-website/edit/master/pages/people.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH: Asserting whether JAVA_HOME is set or not when running "mvn package". When the JAVA_HOME is not set, we are seeing an error that says "bin/javac" not found, "bin/java" not found.
Adding the Assertion that checks for JAVA_HOME is set or not and Errors out with a more intuitive Error Message