Remove unused declarations#848
Conversation
mikewalch
left a comment
There was a problem hiding this comment.
I would just be very careful with API
core/src/main/java/org/apache/accumulo/core/client/summary/CountingSummarizer.java
Show resolved
Hide resolved
|
Reverted the commit that touched the new API. Then reran the code inspection to see what else is now unused. |
|
@mikewalch or @keith-turner you guys OK with the rest of the changes? |
core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java
Show resolved
Hide resolved
...er/base/src/main/java/org/apache/accumulo/server/tabletserver/LargestFirstMemoryManager.java
Show resolved
Hide resolved
|
@ctubbsii thanks for taking a look at this. This was more of an experiment using Intellij Run Inspection by name but it became too cumbersome with our API and pluggable interfaces. I plan on using a more focused approach for removing unused code next time. |
|
@milleruntime I thought this worked out fine. It caught some stuff we maybe didn't want removed... but I think we caught all those in the reviews. Even if we didn't, the risk was minimal, since none of it touched the public API. |
|
Eventually, all our "internal pluggable" stuff should be in declared SPI packages, to make it easier to ensure stability. We're still stuck with the historical stuff for now, though. |
Second commit is questionable whether to remove a new unused parameter before released to API in 2.0. Other removals should all be internal.