Merged
Conversation
* Deleted unused TableParentConfiguration and MapRLogCloser
mikewalch
reviewed
Dec 21, 2018
| public static final int SIZEOF_BYTE = SIZEOF_BOOLEAN; | ||
|
|
||
| /** | ||
| * Size of char in bytes |
Member
There was a problem hiding this comment.
These might be there for completeness.
mikewalch
reviewed
Dec 21, 2018
| } | ||
|
|
||
| public String getZooKeeperRoot() { | ||
| return zooKeeperRoot; |
Member
There was a problem hiding this comment.
This isn't used but might be nice to keep. It could also be added again so I don't have strong feelings
Contributor
Author
There was a problem hiding this comment.
I like to remove stuff like this because it has a cascading effect, allowing removal of more.
mikewalch
reviewed
Dec 21, 2018
| public static final int CONCURRENT_SKIPLISTMAP_ENTRY; | ||
|
|
||
| /** Overhead for ReentrantReadWriteLock */ | ||
| public static final int REENTRANT_LOCK; |
Member
There was a problem hiding this comment.
Not sure about cleaning up this class.
mikewalch
reviewed
Dec 21, 2018
| return; | ||
| } | ||
|
|
||
| s.setRange(ReplicationSection.getRange()); |
Member
There was a problem hiding this comment.
This class looks like it could be useful when debugging replication
Contributor
Author
There was a problem hiding this comment.
Yeah and it is runnable but nothing to run it.
keith-turner
approved these changes
Dec 21, 2018
mikewalch
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed enough where I was able to drop a dependency from one of our poms. Broken up commits by different areas, with one just being general unused code and classes.