ACCUMULO-4195 Added generalized configuration objects for RFile interaction

[ShawnWalker]

Implemented a builder/fluent style of syntax, where each operation creates an operation object with both some methods for setting
parameters and an execute() method to actually invoke the operation.

I'm not really sure if this is in line with the improvement the reporter suggests. It does however address the only goal I can identify with that request: it should be possible to extend the interface FileOperations in a manner such as was done for ACCUMULO-4187 without requiring significant changes to unrelated code.

Also, the automatic formatter hates me, and completely undid most of my eye-pleasing formatting.

[keith-turner]

Seem like this is setting a local var to null.

[keith-turner]

Nevemind. I thought this had no impact, but I was looking at the subtracted lines of the diff. Now I see that it does have an impact.

[joshelser]

@keith-turner how, if at all, does this play into your RFile API work? Have you and Shawn talked about this at all offline?

[joshelser]

Overall, I think this is a nice improvement @ShawnWalker. I really appreciate the quick turn-around on my request! I'll try to run what you have now through some tests locally.

[ShawnWalker]

I changed the method names to look more builder-ish as @joshelser suggested. Wasn't quite sure how the change the verbiage getFileSize(...), so I left it alone.

I also dovetailled NeedsFile into NeedsTableConfiguration, cutting down the signature of the factory methods somewhat.

[joshelser]

Nice, I think these changes look good.

mvn verify -Psunny also passed:

[INFO] Reactor Summary:
[INFO]
[INFO] Apache Accumulo Project ............................ SUCCESS [  5.504 s]
[INFO] Apache Accumulo Fate ............................... SUCCESS [ 45.591 s]
[INFO] Apache Accumulo Start .............................. SUCCESS [01:08 min]
[INFO] Apache Accumulo Core ............................... SUCCESS [03:59 min]
[INFO] Apache Accumulo Server Base ........................ SUCCESS [02:12 min]
[INFO] Apache Accumulo Tracer Server ...................... SUCCESS [ 22.325 s]
[INFO] Apache Accumulo Shell .............................. SUCCESS [ 31.890 s]
[INFO] Apache Accumulo Simple Examples .................... SUCCESS [ 19.693 s]
[INFO] Apache Accumulo GC Server .......................... SUCCESS [ 16.644 s]
[INFO] Apache Accumulo Master Server ...................... SUCCESS [ 27.389 s]
[INFO] Apache Accumulo Monitor Server ..................... SUCCESS [ 21.547 s]
[INFO] Apache Accumulo Tablet Server ...................... SUCCESS [ 58.315 s]
[INFO] Apache Accumulo MiniCluster ........................ SUCCESS [01:23 min]
[INFO] Apache Accumulo Native Libraries ................... SUCCESS [  4.775 s]
[INFO] Apache Accumulo Proxy .............................. SUCCESS [01:05 min]
[INFO] Apache Accumulo Trace .............................. SUCCESS [  6.256 s]
[INFO] Apache Accumulo Iterator Test Harness .............. SUCCESS [  8.341 s]
[INFO] Apache Accumulo Testing ............................ SUCCESS [13:16 min]
[INFO] Apache Accumulo .................................... SUCCESS [  8.178 s]
[INFO] Apache Accumulo Documentation ...................... SUCCESS [  0.415 s]
[INFO] Apache Accumulo Maven Plugin ....................... SUCCESS [ 47.383 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:31 min
[INFO] Finished at: 2016-04-27T13:20:53-04:00
[INFO] Final Memory: 94M/617M
[INFO] ------------------------------------------------------------------------

Any further comments @keith-turner before I merge this in?

[mjwall]

Didn't look too closely, but it struck me this could be cleaned up with another constructor that took a Path and Configuration so it would read
out = FileOperations.getInstance().newWriterBuilder().forFile(file, conf).withTableConfiguration(acuConf)
Fine as is though

[keith-turner]

Any further comments @keith-turner before I merge this in?

Nope. Just took a last look at it. Looks good.

[joshelser]

Nope. Just took a last look at it. Looks good.

Great. Thanks bud. I will merge this in today.