fixes #768 fix race condition in generation of table map#973
Merged
keith-turner merged 1 commit intoapache:1.9from Feb 23, 2019
Merged
fixes #768 fix race condition in generation of table map#973keith-turner merged 1 commit intoapache:1.9from
keith-turner merged 1 commit intoapache:1.9from
Conversation
milleruntime
approved these changes
Feb 21, 2019
|
|
||
| public boolean isCurrent(ZooCache zc) { | ||
| return this.zooCache == zc && this.updateCount == zc.getUpdateCount(); | ||
| } |
Contributor
There was a problem hiding this comment.
This method is nice. Would it be better to use equals comparison?
Contributor
Author
There was a problem hiding this comment.
In this case I wanted to make sure it was the exact same zoocache instance
| if (!map.isCurrent(zc)) { | ||
| instanceToMapCache.invalidate(instance.getInstanceID()); | ||
| map = getTableMap(instance, zc); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to synchronize on the TableMap cache? Or does guava handle that?
Contributor
Author
There was a problem hiding this comment.
Guava handles that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.