Skip to content

fixes #998 handle splitting tablet with no data and files #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith-turner merged 2 commits into from
Mar 7, 2019
Merged

fixes #998 handle splitting tablet with no data and files #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ba88ea
fixes #998 handle splitting tablet with no data and files
keith-turner Feb 28, 2019
273aa1e
avoid Java 1.8 Collections.emptySortedMap()
keith-turner Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import org.slf4j.LoggerFactory;

import com.google.common.base.Optional;
import com.google.common.collect.ImmutableSortedMap;

public class FileUtil {

Expand Down Expand Up @@ -332,8 +333,7 @@ public static SortedMap<Double,Key> findMidPoint(VolumeManager fs, AccumuloConfi
// need to pass original map files, not possibly reduced indexes
return findMidPoint(fs, acuConf, prevEndRow, endRow, origMapFiles, minSplit, false);
}
throw new IOException("Failed to find mid point, no entries between " + prevEndRow + " and "
+ endRow + " for " + mapFiles);
return ImmutableSortedMap.of();
}

// @formatter:off
Expand Down
11 changes: 11 additions & 0 deletions server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,6 +1635,17 @@ private SplitRowSpec findSplitRow(Collection<FileRef> files) {
return null;
}

if (keys.isEmpty()) {
log.info("Cannot split tablet " + extent + ", files contain no data for tablet.");

// set the following to keep tablet from attempting to split until the tablets set of files
// changes.
sawBigRow = true;
timeOfLastMinCWhenBigFreakinRowWasSeen = lastMinorCompactionFinishTime;
Copy link
Copy Markdown
Member

@mikewalch mikewalch Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be another PR but might want to come up with better naming for these variables given they are being used for this case.

Copy link
Copy Markdown
Contributor Author

@keith-turner keith-turner Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that as a follow on change. Do not want them in the same commit.

Copy link
Copy Markdown
Contributor Author

@keith-turner keith-turner Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1016

timeOfLastImportWhenBigFreakinRowWasSeen = lastMapFileImportTime;
return null;
}

// check to see if one row takes up most of the tablet, in which case we can not split
try {

Expand Down