[#2418] Improve performance of IntSequenceGenerator - #2408
Merged
Conversation
This adopts the same approach as LongSequenceGenerator and uses an Atomic field updater to avoid using synchronized. The sequence generator is used by ResponseCorrelator so the existing tests will catch any errors. See https://issues.apache.org/jira/browse/AMQ-7300
cshannon
force-pushed
the
int-sequence-generator-fix
branch
from
August 5, 2026 23:16
7737661 to
074f325
Compare
mattrpav
added this to
Apache ActiveMQ v6.2.9, Apache ActiveMQ v6.3.1 and Apache ActiveMQ v5.19.10
mattrpav
changed the title
cshannon
added a commit
that referenced
this pull request
Aug 6, 2026
This adopts the same approach as LongSequenceGenerator and uses an Atomic field updater to avoid using synchronized. The sequence generator is used by ResponseCorrelator so the existing tests will catch any errors. See https://issues.apache.org/jira/browse/AMQ-7300 (cherry picked from commit 9c3add1)
cshannon
added a commit
that referenced
this pull request
Aug 6, 2026
This adopts the same approach as LongSequenceGenerator and uses an Atomic field updater to avoid using synchronized. The sequence generator is used by ResponseCorrelator so the existing tests will catch any errors. See https://issues.apache.org/jira/browse/AMQ-7300 (cherry picked from commit 9c3add1)
cshannon
added a commit
that referenced
this pull request
Aug 6, 2026
This adopts the same approach as LongSequenceGenerator and uses an Atomic field updater to avoid using synchronized. The sequence generator is used by ResponseCorrelator so the existing tests will catch any errors. See https://issues.apache.org/jira/browse/AMQ-7300 (cherry picked from commit 9c3add1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adopts the same approach as LongSequenceGenerator and uses an Atomic field updater to avoid using synchronized.
The sequence generator is used by ResponseCorrelator so the existing tests will catch any errors.
See https://issues.apache.org/jira/browse/AMQ-7300