AMQ-7309 - Implement Message#isBodyAssignableTo and Message#getBody methods - #979
Merged
Conversation
cshannon
force-pushed
the
AMQ-7309-getbody
branch
from
February 15, 2023 22:49
9cee309 to
154504c
Compare
cshannon
marked this pull request as ready for review
February 15, 2023 22:50
Contributor
Author
|
I think this is ready for review now, I updated the getBody() method to copy into a new object. Can let the CI tests run to make sure I didn't break anything as I had to do a little refactoring to make copying the body simpler. |
cshannon
force-pushed
the
AMQ-7309-getbody
branch
from
February 15, 2023 23:06
154504c to
e86e709
Compare
tabish121
reviewed
Feb 16, 2023
gemmellr
reviewed
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might still need some tweaks but there's some initial tests pushed and wanted to get eyes on it and any feedback.