Moved create_empty_agtype out of loops to avoid repetition#888
Merged
Conversation
Contributor
|
@mohayu22 Please adjust your commit description to the archaic 80 characters per line standard :)
|
To avoid repeated calls inside the loop, "create_empty_agtype" was declared outside the loop and its output was assigned to the "props" variable which is then used inside the loop.
Contributor
Author
|
@jrgemignani Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_empty_agtypecan be classified as a pure function since it does not modify the database, but simply creates an empty agtype.To avoid repeated calls inside the loop,
create_empty_agtypewas declared outside the loop and its output was assigned to thepropsvariable which is then used inside the loop.This approach ensures that the function is only called once and improves the efficiency of the code.