Fix issue #878 - unrecognized node type error#889
Merged
Conversation
- The error was in the way expr was getting transformed in case of T_NullTest. - The original expr was also getting tranformed, causing the nodeType of that expr unrecognizable next time the expr is used. - Fixed by creating a new NullTest expr. - Added regression tests as well.
Contributor
|
@MuhammadTahaNaveed Added a question, otherwise it looks good. |
Member
Author
|
@jrgemignani where? I could not see it. |
Contributor
Member
Author
|
Thats odd.. I dont know why i cant see it. nvm. If we see how other expr types are tranformed, it does not modify the original expr. I think adding a check to see if it was previously tranformed would be an aid rather than solving the main issue. |
jrgemignani
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #878