Skip to content

[AIRFLOW-50] Add bulk_insert_rows() to OracleHook for more performant inserts.#1464

Merged
r39132 merged 1 commit intoapache:masterfrom
geeknam:feature/cx_oracle_bulk_insert
May 5, 2016
Merged

[AIRFLOW-50] Add bulk_insert_rows() to OracleHook for more performant inserts.#1464
r39132 merged 1 commit intoapache:masterfrom
geeknam:feature/cx_oracle_bulk_insert

Conversation

@geeknam
Copy link
Contributor

@geeknam geeknam commented May 4, 2016

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

This has been tested on 1 million rows.

@geeknam geeknam changed the title Add bulk_insert_rows() for more performant inserts. Add bulk_insert_rows() to OracleHook for more performant inserts. May 4, 2016
@coveralls
Copy link

coveralls commented May 4, 2016

Coverage Status

Coverage decreased (-0.2%) to 67.249% when pulling bece6af on geeknam:feature/cx_oracle_bulk_insert into aeb5a07 on airbnb:master.

@r39132
Copy link
Contributor

r39132 commented May 4, 2016

Refer to my comment in your GitHub issue. You need to link this PR to a Jira issue before we can merge it.

@geeknam
Copy link
Contributor Author

geeknam commented May 5, 2016

@r39132 JIRA issue create, this process will just discourage everyone from contributing

@r39132
Copy link
Contributor

r39132 commented May 5, 2016

@geeknam it's part of our move to Apache. It's a new set of tooling that is standard across all Apache projects and also in use in many companies (in the Bay Area). It will slow things down during the transition but it will help us scale better. 5 months ago, we were in the realm of a single company & single committer and the project was not able to scale. As part of the move to apache, we have removed both types of SPOFs.

JIRA : AIRFLOW-50

@criccomini criccomini changed the title Add bulk_insert_rows() to OracleHook for more performant inserts. [AIRFLOW-50] Add bulk_insert_rows() to OracleHook for more performant inserts. May 5, 2016
@criccomini
Copy link
Contributor

LGTM

@r39132 r39132 merged commit 93538f4 into apache:master May 5, 2016
mobuchowski pushed a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
…cies_2.11 to v0.21.1 (apache#1464)

Signed-off-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants