Airflow 2.1.0 delete dag_run when trigger sla

[penggongkui]

when sla happen, not always delete the dag_run, but it happen very frequently

when dag_run is deleted, my unfinished task will not schedule

mysql version: 8
executor: celery
with multi scheduler

if need anything else info please let me know

also, sometimes will call the sla callback twice(it is not the big problem)

[penggongkui]

after dig the mysql binlog, find out it is not delete, it update the dag_run.dag_id to null

[penggongkui]

following is the schedule log, so i think something happened between scheduler_job.py:396 and scheduler_job.py:474

[2021-07-12 00:01:20,754] {scheduler_job.py:396} INFO - Running SLA Checks for data_daily
[2021-07-12 00:01:22,501] {scheduler_job.py:474} INFO - Calling SLA miss callback

[penggongkui]

find the same issue #16896 ,

https://github.com/apache/airflow/blob/2.1.0/airflow/jobs/scheduler_job.py#L461

this line will use the same logic with delete taskinstance

[ashb]

Duplicate of #16934

[uranusjr]

@ash This is #16934, did you tag the wrong issue?

[ashb]

🤦🏻

[ashb]

Duplicate of #16896