Chart should not create Redis secrets while using the KubernetesExecutor

[slmg]

Official Helm Chart version

1.8.0 (latest released)

Apache Airflow version

2.5.1

Kubernetes Version

1.21.14

Helm Chart configuration

# values.yaml

executor: "KubernetesExecutor"

Docker Image customizations

None.

What happened

The redis secrets got created

What you think should happen instead

Given all the resources defined in ./chart/templates/redis contain the below condition, it does not seem right to me to get Redis secrets created in the context of the KubernetesExecutor.

{{- if and .Values.redis.enabled (or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")) }}

Redis secrets might have been missed when this condition was added, because they are located in a different folder?

How to reproduce

Render helm templates

helm template test apache-airflow/airflow --version 1.8.0 --values values.yaml > rendered.yaml

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[hussein-awala]

@slmg assigned you

[amoghrajesh]

Is anyone actively working on this issue @hussein-awala @slmg?
I would not mind fixing this if nobody is working on this now :)

[hussein-awala]

@amoghrajesh there is an open PR #30423, you can read the comments and join the discussion

[amoghrajesh]

I was checking the discussions @hussein-awala. Looks like the PR has gone stale.

[amoghrajesh]

@hussein-awala continuing the effort which went stale here: #32141 in a new PR. Take a look when you have some time, it is a simple conditional added

[amoghrajesh]

As per discussions on this issue itself and the PR: #32141, this looks to be how it is designed and it is expected behaviour here. Closing the issue as expected behaviour.