Skip to content

E2E: Improve Playwright test patterns in BasePage.ts #63038

@choo121600

Description

@choo121600

Description

Refactor BasePage.ts to align with Playwright Best Practices.

This PR focuses on improving test patterns only.
It does not change test coverage or behavior.

Checklist

  • page.waitForFunction() with DOM queries → locator-based waiting
  • page.waitForTimeout() → state-based waiting
  • waitForLoadState("networkidle") → wait for specific UI state
  • Manual assertions → web-first assertions
  • page.evaluate() for DOM manipulation → observe UI state instead
  • CSS :has-text() → user-facing locators

Scope

This issue covers improvements in:

  • pages/BasePage.ts

Notes

  • BasePage.ts is inherited by all page objects, so changes here affect every spec. Please verify that the updated locator still matches the correct element before pr.

Use case/motivation

No response

Related issues

Part of #63036

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:dev-envCI, pre-commit, pylint and other changes that do not change the behavior of the final codegood first issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions