BaseJob does not check return code of a process

[dimberman]

Apache Airflow version: None

Ticket was created 17/Oct/16 22:47

Kubernetes version (if you are using kubernetes) (use kubectl version):

Environment:

• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:
  What happened:

BaseJob ignores the return code of the spawned process. which makes even that process is killed or returned abnormally, it will think it finishes with success

What you expected to happen:

BaseJob should report a failure if the process has a non-zero return.

How to reproduce it:

Anything else we need to know:

Moved here from https://issues.apache.org/jira/browse/AIRFLOW-578