Skip to content

Add additional Cloud Datastore operators#10032

Merged
turbaszek merged 1 commit intoapache:masterfrom
PolideaInternal:datastore-operators
Aug 3, 2020
Merged

Add additional Cloud Datastore operators#10032
turbaszek merged 1 commit intoapache:masterfrom
PolideaInternal:datastore-operators

Conversation

@turbaszek
Copy link
Member

This PR adds more operators for Google Cloud Datastore
service. It also adds missing tests and how-to guides.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@turbaszek turbaszek added provider:google Google (including GCP) related issues area:providers labels Jul 28, 2020
@turbaszek turbaszek requested a review from mik-laj July 28, 2020 10:32
@turbaszek
Copy link
Member Author

@olchas @anitakar would you mind reviewing?

Possibly related #10014

@olchas
Copy link
Contributor

olchas commented Jul 30, 2020

Apart from comments made by @mik-laj, it looks good to me.

@turbaszek turbaszek force-pushed the datastore-operators branch from f7136c8 to 530cfcd Compare July 30, 2020 09:50
This PR adds more operators for Google Cloud Datastore
service. It also adds missing tests and how-to guides.
@turbaszek turbaszek force-pushed the datastore-operators branch from 530cfcd to f8e1335 Compare August 3, 2020 09:27
@turbaszek turbaszek requested review from mik-laj and potiuk August 3, 2020 09:50
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,173 @@
.. Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbaszek turbaszek merged commit 6efa1b9 into apache:master Aug 3, 2020
@turbaszek turbaszek deleted the datastore-operators branch August 3, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments