prevent DAG callback exception from crashing scheduler#10096
Merged
potiuk merged 3 commits intoapache:masterfrom Aug 6, 2020
Merged
prevent DAG callback exception from crashing scheduler#10096potiuk merged 3 commits intoapache:masterfrom
potiuk merged 3 commits intoapache:masterfrom
Conversation
potiuk
requested changes
Aug 2, 2020
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice! But I think this is sort-of breaking change so we should likely make a note about it in the UPDATING.md
turbaszek
approved these changes
Aug 2, 2020
Member
turbaszek
left a comment
turbaszek
left a comment
There was a problem hiding this comment.
Looks good but as Jarek mentioned we should add a not to UPDATING.md. I like the idea of Context type!
houqp
force-pushed
the
dag_callback
branch
3 times, most recently
from
61b512e to
22ecb53
Compare
Member
Author
|
Added entry in UPDATING.md as well as added a counter metric to help better monitor this issue. |
turbaszek
approved these changes
Aug 3, 2020
houqp
force-pushed
the
dag_callback
branch
2 times, most recently
from
42c587b to
c782ef2
Compare
Member
Author
|
@turbaszek @potiuk fixed all test errors, ready for another round of review. |
turbaszek
approved these changes
Aug 4, 2020
mik-laj
reviewed
Aug 5, 2020
potiuk
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds type annotation so we can catch signal type exceptions at build time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.