Skip to content

Updated parameter definition docs for filesystem.py#10159

Merged
mik-laj merged 1 commit intoapache:masterfrom
ypatankar:fix-docs
Aug 5, 2020
Merged

Updated parameter definition docs for filesystem.py#10159
mik-laj merged 1 commit intoapache:masterfrom
ypatankar:fix-docs

Conversation

@ypatankar
Copy link
Copy Markdown
Contributor

Updated the docs with correct parameter name "filepath" under "type"

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Aug 4, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj mik-laj merged commit 8527b14 into apache:master Aug 5, 2020
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Aug 5, 2020

Awesome work, congrats on your first merged pull request!

@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Aug 5, 2020

Hello.

I am very glad that you wanted to contribute to our project.
What are your plans for your next contribution?

Love,
Kamil Breguła

@ypatankar ypatankar deleted the fix-docs branch August 5, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants