Skip to content

Comments

Add correct signatures for operators in amazon provider package#10167

Merged
mik-laj merged 2 commits intoapache:masterfrom
ephraimbuddy:incorrect-signature-aws
Aug 5, 2020
Merged

Add correct signatures for operators in amazon provider package#10167
mik-laj merged 2 commits intoapache:masterfrom
ephraimbuddy:incorrect-signature-aws

Conversation

@ephraimbuddy
Copy link
Contributor

This PR closes part of #9942, It enforces keyword-only arguments for amazon provider operators

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Aug 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #10167 into master will increase coverage by 28.92%.
The diff coverage is 49.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #10167       +/-   ##
===========================================
+ Coverage    6.22%   35.14%   +28.92%     
===========================================
  Files         946     1037       +91     
  Lines       45695    49927     +4232     
===========================================
+ Hits         2846    17549    +14703     
+ Misses      42849    32378    -10471     
Flag Coverage Δ
#mysql-tests-Integration-3.7-5.7 34.78% <48.78%> (?)
#mysql-tests-Integration-3.8-5.7 35.04% <49.39%> (?)
#postgres-tests-Integration-3.6-10 34.76% <48.78%> (?)
#postgres-tests-Integration-3.6-9.6 34.76% <48.78%> (?)
#postgres-tests-Integration-3.7-10 34.76% <48.78%> (?)
#postgres-tests-Integration-3.7-9.6 34.76% <48.78%> (?)
#sqlite-tests-Integration-3.6 34.21% <43.42%> (?)
#sqlite-tests-Integration-3.8 34.47% <44.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
airflow/api/auth/backend/default.py 0.00% <0.00%> (-69.24%) ⬇️
airflow/api/auth/backend/deny_all.py 0.00% <0.00%> (ø)
airflow/api/client/json_client.py 0.00% <0.00%> (ø)
airflow/cli/commands/db_command.py 36.17% <ø> (+36.17%) ⬆️
airflow/cli/commands/info_command.py 35.67% <ø> (+35.67%) ⬆️
airflow/cli/commands/task_command.py 23.71% <0.00%> (+23.71%) ⬆️
airflow/config_templates/default_celery.py 52.94% <ø> (+52.94%) ⬆️
...rflow/config_templates/default_webserver_config.py 0.00% <0.00%> (ø)
airflow/contrib/__init__.py 0.00% <0.00%> (ø)
...low/contrib/hooks/azure_container_instance_hook.py 0.00% <ø> (ø)
... and 966 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1437cb7...e578c7f. Read the comment docs.

@mik-laj mik-laj merged commit 9667314 into apache:master Aug 5, 2020
@ephraimbuddy ephraimbuddy deleted the incorrect-signature-aws branch August 6, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants