Add GCP Bigtable Update Instance Hook/Operator#10340
Merged
turbaszek merged 1 commit intoapache:masterfrom Aug 16, 2020
Merged
Conversation
boring-cyborg
bot
added
area:docs
provider:google
ryanyuan
force-pushed
the
feature/add-bigtable-update-instance
branch
from
4032779 to
24dde30
Compare
Contributor
Author
|
@turbaszek @mik-laj PTAL |
turbaszek
approved these changes
Aug 15, 2020
Member
turbaszek
left a comment
turbaszek
left a comment
There was a problem hiding this comment.
Looks good to me! Only one small suggestion
Member
There was a problem hiding this comment.
Nice! I didn't know that timeout can be passed like that 👍
Contributor
Author
There was a problem hiding this comment.
Same. Until I saw the timeout usage here in documentation:
https://googleapis.dev/python/bigtable/latest/instance.html#google.cloud.bigtable.instance.Instance.create
Add Bigtable Update Instance Hook/Operator
ryanyuan
force-pushed
the
feature/add-bigtable-update-instance
branch
from
24dde30 to
a2a5046
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GCP Bigtable Update Instance Hook/Operator.
closes: #10339
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.