Fixes rat-check pre-commit in case Airflow is added as subrepo#10347
Merged
potiuk merged 1 commit intoapache:masterfrom Aug 15, 2020
Merged
Fixes rat-check pre-commit in case Airflow is added as subrepo#10347potiuk merged 1 commit intoapache:masterfrom
potiuk merged 1 commit intoapache:masterfrom
Conversation
In case Apache Airflow directory is added as subrepo, a new .gitrepo file is created in the Airflow sources. When you try to run pre-commit checks, the RAT check fails in this case. Adding it to .rat-excludes fixes the problem
Member
Author
|
cc: @jaketf |
mik-laj
approved these changes
Aug 15, 2020
kaxil
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case Apache Airflow directory is added as subrepo, a new
.gitrepo file is created in the Airflow sources. When you try to
run pre-commit checks, the RAT check fails in this case.
Adding it to .rat-excludes fixes the problem
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.