Skip to content

Conversation

@derrickqin
Copy link
Contributor

Add support for creating multiple replicated clusters in Bigtable hook and operator

closes: #10474

Changes:

  1. Added a new parameter called replica_clusters to allow creating multiple Bigtable replicated clusters
  2. Made existing replica_cluster_id and replica_cluster_zone deprecated, but still working
  3. Added unit tests for both hook and operator

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Aug 22, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 22, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@derrickqin derrickqin marked this pull request as draft August 22, 2020 13:45
@derrickqin derrickqin marked this pull request as ready for review August 22, 2020 13:48
@derrickqin
Copy link
Contributor Author

@turbaszek @ryanyuan PTAL. Thanks!

@derrickqin
Copy link
Contributor Author

@turbaszek could you please merge it? Thanks!

@turbaszek
Copy link
Member

@derrickqin would you mind rebasing onto current master? There seems to be an issue with CI :<

@derrickqin derrickqin force-pushed the support-bigtable-multiple-replicas branch from 0ad3e12 to 3b61efc Compare August 23, 2020 10:23
@derrickqin
Copy link
Contributor Author

@turbaszek could you please have another look? CI build failed on Quarantined tests, don't think it is related to my change...
Thanks!

@potiuk
Copy link
Member

potiuk commented Aug 23, 2020

Quarantined builds fail from time to time.

@turbaszek turbaszek merged commit b0598b5 into apache:master Aug 24, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 24, 2020

Awesome work, congrats on your first merged pull request!

potiuk added a commit to PolideaInternal/airflow that referenced this pull request Aug 24, 2020
@potiuk
Copy link
Member

potiuk commented Aug 24, 2020

Hello @derrickqin -> I believe merging that change broke our master. It's most likely not your fault, it's either some coincidence/race between your changes/master changes or a problem I described in #10471.

I am going to investigate it, but it would help tremendously if you rebase your local branch to latest master (after we merge #10522), and then re-submit the PR again - so that we could see what was the root cause of the problem ?

That would be super helpful if you do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for creating multiple replicated clusters in Bigtable hook and operator

4 participants