-
Notifications
You must be signed in to change notification settings - Fork 16.2k
Add support for creating multiple replicated clusters in Bigtable hook and operator #10475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for creating multiple replicated clusters in Bigtable hook and operator #10475
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
|
@turbaszek @ryanyuan PTAL. Thanks! |
|
@turbaszek could you please merge it? Thanks! |
|
@derrickqin would you mind rebasing onto current master? There seems to be an issue with CI :< |
0ad3e12 to
3b61efc
Compare
|
@turbaszek could you please have another look? CI build failed on Quarantined tests, don't think it is related to my change... |
|
Quarantined builds fail from time to time. |
|
Awesome work, congrats on your first merged pull request! |
…able hook and operator (apache#10475)" This reverts commit b0598b5.
|
Hello @derrickqin -> I believe merging that change broke our master. It's most likely not your fault, it's either some coincidence/race between your changes/master changes or a problem I described in #10471. I am going to investigate it, but it would help tremendously if you rebase your local branch to latest master (after we merge #10522), and then re-submit the PR again - so that we could see what was the root cause of the problem ? That would be super helpful if you do that. |
Add support for creating multiple replicated clusters in Bigtable hook and operator
closes: #10474
Changes:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.