Skip to content

Fix typo in Facebook Ads Provider #10484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Aug 22, 2020
Merged

Fix typo in Facebook Ads Provider #10484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow/providers/facebook/ads/hooks/ads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ def facebook_ads_config(self) -> Dict:
self.log.info("Fetching fb connection: %s", self.facebook_conn_id)
conn = self.get_connection(self.facebook_conn_id)
config = conn.extra_dejson
missings_keys = self.client_required_fields - config.keys()
if missings_keys:
message = "{missings_keys} fields are missing".format(missings_keys=missings_keys)
missing_keys = self.client_required_fields - config.keys()
if missing_keys:
message = "{missing_keys} fields are missing".format(missing_keys=missing_keys)
raise AirflowException(message)
return config

Expand Down
6 changes: 3 additions & 3 deletions tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ def provide_facebook_connection(
)
with open(key_file_path, 'r') as credentials:
creds = json.load(credentials)
missings_keys = CONFIG_REQUIRED_FIELDS - creds.keys()
if missings_keys:
message = "{missings_keys} fields are missing".format(missings_keys=missings_keys)
missing_keys = CONFIG_REQUIRED_FIELDS - creds.keys()
if missing_keys:
message = "{missing_keys} fields are missing".format(missing_keys=missing_keys)
raise AirflowException(message)
conn = Connection(
conn_id=FACEBOOK_CONNECTION_ID,
Expand Down