Skip to content

Fix impersonation related bug in bigtable tests#10521

Merged
kaxil merged 1 commit intoapache:masterfrom
PolideaInternal:fix-big-table-impersonation-test-bug
Aug 24, 2020
Merged

Fix impersonation related bug in bigtable tests#10521
kaxil merged 1 commit intoapache:masterfrom
PolideaInternal:fix-big-table-impersonation-test-bug

Conversation

@olchas
Copy link
Contributor

@olchas olchas commented Aug 24, 2020

This PR fixes bugs in two BigTable tests introduced in #10052 related to not including impersonation_chain in the list of arguments BigTableHook is called with.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Aug 24, 2020
@olchas
Copy link
Contributor Author

olchas commented Aug 24, 2020

@potiuk I believe this might be the reason for broken master.

@potiuk
Copy link
Member

potiuk commented Aug 24, 2020

@potiuk I believe this might be the reason for broken master.

Cool! Thanks! So this is one of those cases where two related changed crossed . I will cancel my revert then :)

@kaxil kaxil merged commit fef73b9 into apache:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments