Skip to content

Move dag's cli method out of DAG.#10566

Closed
potiuk wants to merge 1 commit intoapache:masterfrom
PolideaInternal:remove-dag-cli-method
Closed

Move dag's cli method out of DAG.#10566
potiuk wants to merge 1 commit intoapache:masterfrom
PolideaInternal:remove-dag-cli-method

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 25, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested review from kaxil and mik-laj August 25, 2020 21:30
@mik-laj
Copy link
Member

mik-laj commented Aug 25, 2020

I wonder if it would be better to delete it. This was helpful when it was easy available, but that leads to a lot of problems. The basic thing is that we have to support running DAGs that have not been loaded by DagBag, so we have to do many things when import airflow e.g. add new path to sys.path, loading plugins, etc. If we do not prepare the environment while the airflow import is being done, loading the DAG File may fail.

@potiuk potiuk force-pushed the remove-dag-cli-method branch from d763a35 to 4f541b5 Compare August 25, 2020 22:11
@potiuk
Copy link
Member Author

potiuk commented Aug 25, 2020

I wonder if it would be better to delete it. This was helpful when it was easy available, but that leads to a lot of problems. The basic thing is that we have to support running DAGs that have not been loaded by DagBag, so we have to do many things when import airflow e.g. add new path to sys.path, loading plugins, etc. If we do not prepare the environment while the airflow import is being done, loading the DAG File may fail.

Maybe as a next move. For now I want to focus on deps.

@potiuk
Copy link
Member Author

potiuk commented Aug 25, 2020

But If you want to remove it - feel free :)

@mik-laj
Copy link
Member

mik-laj commented Aug 25, 2020

We may think about it later. This change now needs an entry in UPDATING.md anyway.

@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 12, 2020
@potiuk potiuk force-pushed the remove-dag-cli-method branch from 4f541b5 to 4e877b5 Compare October 22, 2020 17:23
@stale stale bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 22, 2020
@potiuk potiuk closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants