Add masterConfig parameter to MLEngineStartTrainingJobOperator#10578
Merged
mik-laj merged 7 commits intoapache:masterfrom Sep 4, 2020
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Contributor
Author
|
It seems spell checks failed but I don't recognize where is the error. If someone would help me with this |
Member
|
Can you add tests to avoid regression? |
e3fa9b5 to
64981bc
Compare
1634a3f to
dda2335
Compare
mik-laj
reviewed
Sep 3, 2020
mik-laj
approved these changes
Sep 4, 2020
|
Awesome work, congrats on your first merged pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
My PR addresses the following Airflow Jira issues and references them in the PR title.
https://issues.apache.org/jira/browse/AAR-487
Description
Why this is important?
At the moment when you spin up a training, you cannot specify an accelerator, so when you end up with a CUSTOM tier and a standard machine, you cannot add GPUs that would speed up the training process.
Documentation
It refers to the follow REST API Documentation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.