Skip to content

Comments

Improve Docstring for AWS Athena Hook/Operator#10580

Merged
XD-DENG merged 3 commits intoapache:masterfrom
amariucaitheodor:master
Aug 26, 2020
Merged

Improve Docstring for AWS Athena Hook/Operator#10580
XD-DENG merged 3 commits intoapache:masterfrom
amariucaitheodor:master

Conversation

@amariucaitheodor
Copy link
Contributor

closes: #10575
related: #10575

@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Aug 26, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 26, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@XD-DENG XD-DENG changed the title Made AWS Athena parameter more explicit Improve Docstring for AWS Athena Hook/Operator Aug 26, 2020
Copy link
Member

@XD-DENG XD-DENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theodor1289 . I updated the PR subject a little bit, hope you don't mind

@XD-DENG XD-DENG merged commit 8349061 into apache:master Aug 26, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 26, 2020

Awesome work, congrats on your first merged pull request!

@XD-DENG XD-DENG added this to the Airflow 1.10.13 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing parameter

2 participants