Skip to content

Fix missing dash in flag for statsd container#10691

Merged
kaxil merged 1 commit intoapache:masterfrom
PolideaInternal:fix-statsd-exporter-flag
Sep 2, 2020
Merged

Fix missing dash in flag for statsd container#10691
kaxil merged 1 commit intoapache:masterfrom
PolideaInternal:fix-statsd-exporter-flag

Conversation

@olchas
Copy link
Contributor

@olchas olchas commented Sep 2, 2020

This PR fixes a bug in the definition of statsd container in helm-chart.

With current master helm-chart the airflow-statsd pod fails and collecting logs from the pod with kubectl logs returns the message:

statsd_exporter: error: unknown short flag '-s', try --help

Following the suggestion from prometheus/statsd_exporter#155, I have added additional dash to -statsd.mapping-config flag in the definition of statsd container inside statsd-deployment.yaml file, which seems to fix the pod.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Sep 2, 2020
@kaxil kaxil merged commit 48ce4bd into apache:master Sep 2, 2020
potiuk pushed a commit that referenced this pull request Nov 15, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com>
(cherry picked from commit 48ce4bd)
@potiuk potiuk added the type:bug-fix Changelog: Bug Fixes label Nov 15, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 15, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com>
(cherry picked from commit 48ce4bd)
potiuk pushed a commit that referenced this pull request Nov 16, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com>
(cherry picked from commit 48ce4bd)
kaxil pushed a commit that referenced this pull request Nov 18, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com>
(cherry picked from commit 48ce4bd)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com>
(cherry picked from commit 48ce4bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants