Fix missing dash in flag for statsd container#10691
Merged
kaxil merged 1 commit intoapache:masterfrom Sep 2, 2020
Merged
Conversation
potiuk
approved these changes
Sep 2, 2020
kaxil
approved these changes
Sep 2, 2020
potiuk
pushed a commit
that referenced
this pull request
Nov 15, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com> (cherry picked from commit 48ce4bd)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com> (cherry picked from commit 48ce4bd)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com> (cherry picked from commit 48ce4bd)
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com> (cherry picked from commit 48ce4bd)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Co-authored-by: Kamil Olszewski <kamil.olszewski@polidea.com> (cherry picked from commit 48ce4bd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the definition of
statsdcontainer in helm-chart.With current master helm-chart the
airflow-statsdpod fails and collecting logs from the pod withkubectl logsreturns the message:statsd_exporter: error: unknown short flag '-s', try --helpFollowing the suggestion from prometheus/statsd_exporter#155, I have added additional dash to
-statsd.mapping-configflag in the definition ofstatsdcontainer insidestatsd-deployment.yamlfile, which seems to fix the pod.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.