Conversation
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as apache#9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following apache#10576 and this change will be of great help.
bfd20d7 to
e8fb341
Compare
|
CC: @OmairK - I am also going to add more and more unit tests for the bash functions of Breeze. This PR makes it super-easy to write and run new tests, so you might want to give it a try :). BATS provides a very nice framework to test bash functions - and in this PR I also added https://github.com/bats-core/bats-assert and https://github.com/bats-core/bats-support and https://github.com/bats-core/bats-file which provide a really structured and straightforward way to write asserts (assert output of a function, whether a file exists, whether the function failed or succeeded and the like). It's rather easy to write new tests:
the test above runs |
|
Others - with this one and few other changes implemented recently (and follow up tests)- our Bash scripts will become almost as good as structured python code :) |
|
All green, just quarantine tests failed :) |
|
Would love to get that in, so I can add more unit tests while adding the "Google Shell guidelines" compatibility :) |
|
Thanks @kaxil! |
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as apache#9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following apache#10576 and this change will be of great help. (cherry picked from commit e4de728)
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as #9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following #10576 and this change will be of great help. (cherry picked from commit e4de728)
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as apache#9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following apache#10576 and this change will be of great help. (cherry picked from commit e4de728)
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as #9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following #10576 and this change will be of great help. (cherry picked from commit e4de728)
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as #9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following #10576 and this change will be of great help. (cherry picked from commit e4de728)
BATS has additional libraries of asserts that are much more straightforward and nicer to write tests for bash scripts There is no dockerfile from BATS that contains those, so we had to build our own (but it follows the same structure as apache#9652 - where we keep our dev docker image sources inside our repository and the generated docker images in "apache/airflow:<tool>-CALVER-TOOLVER format. We have more BATS unit test to add - following apache#10576 and this change will be of great help. (cherry picked from commit e4de728)
BATS has additional libraries of asserts that are much more
straightforward and nicer to write tests for bash scripts
There is no dockerfile from BATS that contains those, so we
had to build our own (but it follows the same structure
as #9652 - where we keep our dev docker image
sources inside our repository and the generated docker images
in "apache/airflow:-CALVER-TOOLVER format.
We have more BATS unit test to add - following #10576
and this change will be of great help.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.