Skip to content

Comments

Update node installation cmd#10744

Merged
potiuk merged 1 commit intoapache:masterfrom
ryanyuan:docs/update-node-installation-cmd
Sep 5, 2020
Merged

Update node installation cmd#10744
potiuk merged 1 commit intoapache:masterfrom
ryanyuan:docs/update-node-installation-cmd

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Sep 5, 2020

In CONTRIBUTING.rst, we have brew install node --without-npm for installing node in macOS. The --without-npm flag is outdated and running this command will throw Error: invalid option: --without-npm.

closes: #10743

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potiuk potiuk merged commit d84b62d into apache:master Sep 5, 2020
@potiuk
Copy link
Member

potiuk commented Sep 5, 2020

Thanks @ryanyuan !

@ryanyuan
Copy link
Contributor Author

ryanyuan commented Sep 6, 2020

Cheers. @potiuk

potiuk pushed a commit that referenced this pull request Nov 14, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
kaxil pushed a commit that referenced this pull request Nov 18, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Update node installation command

2 participants