Fix dockerfile hadolint problems#10754
Merged
potiuk merged 1 commit intoapache:masterfrom Sep 6, 2020
Merged
Conversation
mik-laj
approved these changes
Sep 5, 2020
kaxil
reviewed
Sep 5, 2020
Member
Author
|
I need the #10750 to be meerged first :( |
potiuk
force-pushed
the
fix-dockerfile-hadolint-problems
branch
from
6285c68 to
18ba2e8
Compare
Member
|
Can you please add a PR description, I would love to help the community understand what the PR actually fixes. As little as "fixes formatting" (just an example) is helpful for the community to understand when they see the PR |
potiuk
force-pushed
the
fix-dockerfile-hadolint-problems
branch
2 times, most recently
from
913d605 to
9fccb46
Compare
Member
Author
Good Idea. Added. I also made comments in the Dockerfiles where iItook deliberate version of ignoring a rule explaining why I did so. |
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
potiuk
force-pushed
the
fix-dockerfile-hadolint-problems
branch
from
9fccb46 to
7fce5be
Compare
Member
Author
|
Also added explanation what each ignored rule means and link to the wiki describing them . |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` (cherry picked from commit e3c83da)
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` (cherry picked from commit e3c83da)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` (cherry picked from commit e3c83da)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` (cherry picked from commit e3c83da)
potiuk
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` (cherry picked from commit e3c83da)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
The hadolint check only checked the "main dir" Dockerfile but we have more of them now. All of them are now checked. The following problems are fixed: * DL3000 Use absolute WORKDIR * DL4000 MAINTAINER is deprecated * DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. * SC2046 Quote this to prevent word splitting. The followiing problems are ignored: * DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` (cherry picked from commit e3c83da)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hadolint check only checked the "main dir" Dockerfile
but we have more of them now. All of them are now checked.
The following problems are fixed:
The followiing problems are ignored:
apk add <package>useapk add <package>=<version>^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.