Fetching databricks host from connection if not supplied in extras.#10762
Fetching databricks host from connection if not supplied in extras.#10762XD-DENG merged 2 commits intoapache:masterfrom
Conversation
|
Hi @joshi95 , looks good to me. May you rebase? |
|
On the other hand, before I can merge, the test you added doesn't make much sense to me. May you clarify a bit or enhance it further? |
Hi, In this test I have reused the existing TestDatabricksHookToken testcase with one less extra argument ie {'token': TOKEN} instead of {'token': TOKEN, 'host': HOST} |
15cafc7 to
384f2cf
Compare
|
I see. Thanks for the clarification. May you rebase? Once ci is green I would be happy to merge. Thanks. |
Yes thanks, Have rebased . |
|
Hi not sure why k8s ci test has failed. |
|
Possibly a transient error. I have restarted the CI, let’s see if it will be ok |
thanks |
|
Thanks @joshi95 for the contribution 😃 |
Fix for the issue #10726 . Have supported the previous functionality of fetching the host from extras if specified else it is getting fetched from the databricks connection which makes more sense.