-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add Plugins View in web UI #10770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plugins View in web UI #10770
Conversation
|
@mjpieters Can you look at it? Does it meet your expectations? |
|
The original ticket mentions the following requirements. What do you think to add them? |
|
@mik-laj currently while loading the plugins from either of the sources, we're not keeping the information about the source, path etc. To get this information, we'd need to probably introduce two attributes (something like In the case of airflow plugins directory based plugins: Let me know what do you think. |
|
The point of my request was to make it visible where the plugin was loaded from, and what version information we have (if any). Our cluster setup is somewhat complicated with mixed virtualenv and conda layers, being able to see where distutils pulled the plugin from is quite important. So while this looks cool, it's not what I had in mind. |
|
hey @mjpieters: Got that. This is a WIP, we're still discussing some of the changes to do that. |
1b0bb3d to
08441f5
Compare
|
@mjpieters: I've added the plugin source and path attributes. Source tells whether the plugin was loaded from the plugins directory or from the entrypoint package. Plugin Path shows the absolute path of the package in case it's loaded from plugins directory, otherwise shows |
08441f5 to
06d4b28
Compare
06d4b28 to
c12587e
Compare
|
@mjpieters Thank you for all the suggestions. Please have a look now. Now we've just one attribute called |
c12587e to
37a5601
Compare
mjpieters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing all my suggestions! 🎺
|
@rootcss Can you please rebase the PR on latest master again 🙏 |
37a5601 to
5ff83c0
Compare
|
@kaxil I've rebased and pushed. |
|
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
c971880 to
de8971f
Compare
|
tests are failing |
8372214 to
85c3519
Compare
85c3519 to
1c4fcf6
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
1c4fcf6 to
aad57de
Compare
|
@kaxil 3 checks have failed, but I don't see any error messages. Is it a known thing by any chance? |
|
@rootcss I restarted the build. |
|
@mik-laj that fixed it. Thanks. |
This PR adds a link to view details of Plugins loaded into the Airflow.
closes: #9185
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.