Skip to content

Add prerequisite to add-dag-tags documentation#10852

Closed
tiago-palma wants to merge 3 commits intoapache:v1-10-testfrom
tiago-palma:patch-2
Closed

Add prerequisite to add-dag-tags documentation#10852
tiago-palma wants to merge 3 commits intoapache:v1-10-testfrom
tiago-palma:patch-2

Conversation

@tiago-palma
Copy link

Add a UI prerequisite section explaining that RBAC needs to be enabled.

Add a UI prerequisite section explaining that RBAC needs to be enabled.
@potiuk
Copy link
Member

potiuk commented Sep 10, 2020

This is cool, but can you make this change to master as well before we merge it please? The process we have that people usually add the changes to master and cherry-pick them to 1.10 afterwards. But it's ok also to have two parallel PRs.

@potiuk
Copy link
Member

potiuk commented Sep 10, 2020

(BTW in master there is no need to mention RBAC as this is the only option).

@tiago-palma
Copy link
Author

(BTW in master there is no need to mention RBAC as this is the only option).

In master these files already exist, the only difference is that it does not have the Prerequisite section

@potiuk
Copy link
Member

potiuk commented Sep 10, 2020

Ah I see ! cool!

@potiuk
Copy link
Member

potiuk commented Sep 10, 2020

I think there is a consistent problem that we hit with the tests. I am going to cherry-pick my changes for master soon to fix those. Would you mind waiting a couple of days before I do that and rebase ? (Monday it shoudl be ready).

@tiago-palma
Copy link
Author

I think there is a consistent problem that we hit with the tests. I am going to cherry-pick my changes for master soon to fix those. Would you mind waiting a couple of days before I do that and rebase ? (Monday it shoudl be ready).

Sure, not rush from my side. Thank you

@potiuk potiuk force-pushed the v1-10-test branch 3 times, most recently from 8644aa9 to ea36166 Compare September 18, 2020 11:07
@potiuk potiuk force-pushed the v1-10-test branch 2 times, most recently from bd4214b to 195f00d Compare October 3, 2020 22:42
Comment on lines +45 to +49
**UI Prerequisite**:

The web UI with RBAC feature needs to be enabled; otherwise, the UI
will not allow you to filter DAGs using tags nor show you the tag
labels. No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 2.0 (which is where the master branch is going to be released as) this section isn't needed as the RBAC UI is the only one that exists

Suggested change
**UI Prerequisite**:
The web UI with RBAC feature needs to be enabled; otherwise, the UI
will not allow you to filter DAGs using tags nor show you the tag
labels.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to have this prerequisite section for the documentation >=1.10.8 and <2.0 for those who do not have the latest installed.
For documentation >= 2.0, the prerequisite section can simply disappear?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In master these files already exist, the only difference is that it does not have the Prerequisite section

#10852 (comment)

@mik-laj mik-laj requested a review from ashb October 19, 2020 11:57
@kaxil kaxil force-pushed the v1-10-test branch 2 times, most recently from c4c1cab to 91a1305 Compare November 12, 2020 21:07
@potiuk potiuk force-pushed the v1-10-test branch 7 times, most recently from 00f320f to 94a6f6f Compare November 14, 2020 17:57
@potiuk potiuk force-pushed the v1-10-test branch 2 times, most recently from 8bdd442 to 0122893 Compare November 16, 2020 15:18
@kaxil kaxil closed this Nov 17, 2020
@kaxil kaxil deleted the branch apache:v1-10-test November 17, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants