Add prerequisite to add-dag-tags documentation#10852
Add prerequisite to add-dag-tags documentation#10852tiago-palma wants to merge 3 commits intoapache:v1-10-testfrom
Conversation
98d702f to
21d311b
Compare
Add a UI prerequisite section explaining that RBAC needs to be enabled.
21d311b to
0327bd4
Compare
|
This is cool, but can you make this change to master as well before we merge it please? The process we have that people usually add the changes to master and cherry-pick them to 1.10 afterwards. But it's ok also to have two parallel PRs. |
|
(BTW in master there is no need to mention RBAC as this is the only option). |
In master these files already exist, the only difference is that it does not have the Prerequisite section |
|
Ah I see ! cool! |
|
I think there is a consistent problem that we hit with the tests. I am going to cherry-pick my changes for master soon to fix those. Would you mind waiting a couple of days before I do that and rebase ? (Monday it shoudl be ready). |
Sure, not rush from my side. Thank you |
8644aa9 to
ea36166
Compare
bd4214b to
195f00d
Compare
| **UI Prerequisite**: | ||
|
|
||
| The web UI with RBAC feature needs to be enabled; otherwise, the UI | ||
| will not allow you to filter DAGs using tags nor show you the tag | ||
| labels. No newline at end of file |
There was a problem hiding this comment.
For 2.0 (which is where the master branch is going to be released as) this section isn't needed as the RBAC UI is the only one that exists
| **UI Prerequisite**: | |
| The web UI with RBAC feature needs to be enabled; otherwise, the UI | |
| will not allow you to filter DAGs using tags nor show you the tag | |
| labels. |
There was a problem hiding this comment.
The idea was to have this prerequisite section for the documentation >=1.10.8 and <2.0 for those who do not have the latest installed.
For documentation >= 2.0, the prerequisite section can simply disappear?
There was a problem hiding this comment.
In master these files already exist, the only difference is that it does not have the Prerequisite section
c4c1cab to
91a1305
Compare
00f320f to
94a6f6f
Compare
8bdd442 to
0122893
Compare
Add a UI prerequisite section explaining that RBAC needs to be enabled.