Skip to content

Fix breeze -i error#10887

Merged
potiuk merged 1 commit intoapache:masterfrom
astronomer:breeze-integration-flag-fix
Sep 11, 2020
Merged

Fix breeze -i error#10887
potiuk merged 1 commit intoapache:masterfrom
astronomer:breeze-integration-flag-fix

Conversation

@ashb
Copy link
Member

@ashb ashb commented Sep 11, 2020

It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.
@ashb ashb requested review from kaxil and potiuk and removed request for potiuk September 11, 2020 17:15
@potiuk
Copy link
Member

potiuk commented Sep 11, 2020

one lowercase too much

@potiuk
Copy link
Member

potiuk commented Sep 11, 2020

Hmm . but this is strange. It shoudl work actually, was it 'undefined' because there was no actual integration after -i ?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. It should work let me check it.

@ashb
Copy link
Member Author

ashb commented Sep 11, 2020

Changing it definately made it work and behave as expected. ./breeeze -b mysql -i redis -i rabbitmq was what I was running.

-i | --integration)
local integration=${2}
local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
parameters::check_and_save_allowed_param "integration" "integration" "--integration"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I tired this, and it then couldn't find the list of allowed values.

I will double check

@potiuk
Copy link
Member

potiuk commented Sep 11, 2020

See my suggestion - this was the actual problem -> the "check_and_save_allowed_param" continued checking INTEGRATION variable instead if "integration"

@potiuk
Copy link
Member

potiuk commented Sep 11, 2020

I thought I tired this, and it then couldn't find the list of allowed values.

True,

@potiuk potiuk merged commit 030582a into apache:master Sep 11, 2020
@kaxil kaxil deleted the breeze-integration-flag-fix branch September 11, 2020 21:25
potiuk pushed a commit to potiuk/airflow that referenced this pull request Sep 14, 2020
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.

(cherry picked from commit 030582a)
potiuk pushed a commit that referenced this pull request Sep 15, 2020
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.

(cherry picked from commit 030582a)
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.

(cherry picked from commit 030582a)
kaxil pushed a commit that referenced this pull request Nov 12, 2020
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.

(cherry picked from commit 030582a)
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.

(cherry picked from commit 030582a)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.

(cherry picked from commit 030582a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants